feat: Added getAllQuery utility function#38
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new searchQueryUtil module with a getAllQuery function that parses all URL search parameters from the browser's address bar into an object format. The function handles duplicate query parameter keys by converting them into arrays.
- Added new
searchQueryUtilmodule withgetAllQueryfunction - Updated Vitest configuration to use jsdom environment for DOM-dependent tests
- Exported the new utility module from the main package entry point
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Added jsdom test environment for browser API testing |
| package/searchQueryUtil/index.ts | Module entry point exporting getAllQuery function |
| package/searchQueryUtil/getAllQuery/index.ts | Main implementation of getAllQuery utility function |
| package/searchQueryUtil/getAllQuery/index.test.ts | Test cases for getAllQuery functionality |
| package/index.ts | Added searchQueryUtil export to main package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
어떻게 윈도우 객체에서 테스트를 진행할 수 있을까.. 찾아보다가 jsdom 패키지를 설치하고, environment: "jsdom"을 설정하면 window, document 등 브라우저 객체를 통해 시뮬레이션할 수 있어요! cc. @prgmr99 |
실제 브라우저를 띄우지 않고, 테스트 환경에서 가짜 브라우저를 띄워서 시뮬레이션을 하는 것이군여!!!👍 |
|
승인해주시면 한번 더 버전 업 가봅시다 ㅎㅎ |
prgmr99
left a comment
prgmr99
left a comment
There was a problem hiding this comment.
고생하셨슴다~~!! 정말 유용하게 쓸 수 있을 것 같아요 :)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description